lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8aa17f38-a6f6-4ba9-b38c-767ed39c1c92@roeck-us.net>
Date: Thu, 18 Jul 2024 07:43:39 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Gupta, Akshay" <Akshay.Gupta@....com>, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: gregkh@...uxfoundation.org, arnd@...db.de, naveenkrishna.chatradhi@....com
Subject: Re: [PATCH v2 1/8] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to
 misc

On 7/18/24 03:21, Gupta, Akshay wrote:
> 
> On 7/17/2024 9:56 PM, Guenter Roeck wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On 7/17/24 01:10, Akshay Gupta wrote:
>>> This is done to support other functionality provided by the SBRMI, which
>>> does not fit in the hwmon subsystem.
>>>
>>> - Move the SBRMI core functionality and I2C device probing part to misc.
>>> - Move hwmon device sensor to misc as only power is reported through
>>>    hwmon sensor.
>>>
>>
>> I fail to see the logic here. Why would the supported sensor types
>> be a reason or an argument for moving the hwmon code out of hwmon ?
>>
>> Guenter
>>
> After we move the probe of i2c device to misc, we were using platform_device_register_data()
> 
> API to probe the hwmon sensor. Greg did not like this idea of probing, previously I have explored mfd cells
> 

Yes, if there is a new restriction in the use of platform devices
(outside mfd), this should be documented.

Guenter


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ