linux-kernel - Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240718235105.9e132fe9ff5ac147e3c8e3c9@kernel.org>
Date: Thu, 18 Jul 2024 23:51:05 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: Jiri Olsa <olsajiri@...il.com>, rostedt@...dmis.org,
 mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, bpf@...r.kernel.org, Menglong Dong
 <dongml2@...natelecom.cn>
Subject: Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of
 bpf_kprobe_override

Hi,

On Thu, 18 Jul 2024 09:32:13 +0800
Menglong Dong <menglong8.dong@...il.com> wrote:

> On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
> >
> > On Wed, 10 Jul 2024 15:13:07 +0200
> > Jiri Olsa <olsajiri@...il.com> wrote:
> >
> > > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> > >
> > > should be in Fixes: tag probably ?
> >
> > Yes, I'll add a Fixed tag.
> >
> 
> Hello!
> 
> Should I send a v2 with the "Fixes" tag? It seems that this commit has
> been pending for a while.

No problem, but wait a bit. I need to send this to 6.11-rc1.

Thank you,


> 
> Thanks!
> Menglong Dong
> 
> > >
> > > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > > anymore, and we can remove it now.
> > > >
> > > > Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> > >
> > > lgtm, cc-ing Masami
> > >
> > > Acked-by: Jiri Olsa <jolsa@...nel.org>
> >
> > Thanks!
> >
> > >
> > > jirka
> > >
> > > > ---
> > > >  include/linux/trace_events.h | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > > index 9df3e2973626..9435185c10ef 100644
> > > > --- a/include/linux/trace_events.h
> > > > +++ b/include/linux/trace_events.h
> > > > @@ -880,7 +880,6 @@ do {                                                                    \
> > > >  struct perf_event;
> > > >
> > > >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > > >
> > > >  extern int  perf_trace_init(struct perf_event *event);
> > > >  extern void perf_trace_destroy(struct perf_event *event);
> > > > --
> > > > 2.39.2
> > > >
> > > >
> >
> >
> > --
> > Masami Hiramatsu (Google) <mhiramat@...nel.org>


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>