linux-kernel - Re: ld.lld: error: undefined symbol: iosf_mbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qxyvhit.wl-tiwai@suse.de>
Date: Thu, 18 Jul 2024 17:36:42 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc: Takashi Iwai <tiwai@...e.de>,
	Nathan Chancellor <nathan@...nel.org>,
	kernel test robot <lkp@...el.com>,
	llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
	Bard Liao <bard.liao@...el.com>
Subject: Re: ld.lld: error: undefined symbol: iosf_mbi_available

On Thu, 18 Jul 2024 17:16:54 +0200,
Pierre-Louis Bossart wrote:
> 
> 
> >>>> diff --git a/sound/soc/intel/common/soc-intel-quirks.h
> >>>> b/sound/soc/intel/common/soc-intel-quirks.h
> >>>> index de4e550c5b34..ae67853f7e2e 100644
> >>>> --- a/sound/soc/intel/common/soc-intel-quirks.h
> >>>> +++ b/sound/soc/intel/common/soc-intel-quirks.h
> >>>> @@ -11,7 +11,9 @@
> >>>>
> >>>>  #include <linux/platform_data/x86/soc.h>
> >>>>
> >>>> -#if IS_ENABLED(CONFIG_X86)
> >>>> +#if IS_ENABLED(CONFIG_X86) && \
> >>>> +       (IS_ENABLED(CONFIG_SND_SOC_SOF_BAYTRAIL) || \
> >>>> +        IS_ENABLED(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM_ACPI))
> >>>>
> >>>>  #include <linux/dmi.h>
> >>>>  #include <asm/iosf_mbi.h>
> >>>>
> >>>> also at https://github.com/thesofproject/linux/pull/5114
> >>>
> >>> I'm afraid it's not enough, either.  It's included in
> >>> sound/soc/sof/intel/atom.c, and this one can be built-in by selected
> >>> from others while CONFIG_SND_SOC_SOF_BAYTRAIL=m.  And, the reverse
> >>> selection is done from CONFIG_SND_SOC_SOF_BAYTRAIL -- so
> >>> CONFIG_IOSF_MBI can be m as well, and this can lead to the unresolved
> >>> symbol from the built-in atom.c.
> >>
> >> Fair point, I was only looking at the reported failure where Baytrail
> >> was completely disabled.
> >>
> >> I am not sure though if it makes sense to split hair in N dimensions.
> >> Building Merrifield as y and Baytrail as m is a corner case that
> >> shouldn't exist at all. And it's only an academic compilation issue, in
> >> practice using 'y' would fail at run-time due to the usual firmware load
> >> dependencies...
> > 
> > Surely this kind of bug won't hit anyone in practical use, but it's
> > only about the randconfig failures.  The original report is in the
> > same category, after all.
> > 
> > Maybe another (rather easier) workaround would be to use
> > IS_REACHABLE(), something like below.  This should fix the original
> > issue and the potential mess-up of kconfig dependencies.
> 
> The simplest solution works for me :-)
> 
> Do you want me to send a patch with your Suggested-by: tag or do it
> yourself?

If you can send from your side, it'd be more appreciated ;)


thanks,

Takashi

> 
> > --- a/sound/soc/intel/common/soc-intel-quirks.h
> > +++ b/sound/soc/intel/common/soc-intel-quirks.h
> > @@ -11,7 +11,7 @@
> >  
> >  #include <linux/platform_data/x86/soc.h>
> >  
> > -#if IS_ENABLED(CONFIG_X86)
> > +#if IS_REACHABLE(CONFIG_IOSF_MBI)
> >  
> >  #include <linux/dmi.h>
> >  #include <asm/iosf_mbi.h>