linux-kernel - Re: [syzbot] [crypto?] KASAN: slab-use-after-free Read in handle_mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9rugxJiJTVCr5tdz5_YHcJVFckubQfK6Xn9TCuua5o1JA@mail.gmail.com>
Date: Thu, 18 Jul 2024 18:51:59 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: "Liam R. Howlett" <Liam.Howlett@...cle.com>, "Vlastimil Babka (SUSE)" <vbabka@...nel.org>, 
	syzbot <syzbot+4c882a4a0697c4a25364@...kaller.appspotmail.com>, 
	akpm@...ux-foundation.org, davem@...emloft.net, herbert@...dor.apana.org.au, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, syzkaller-bugs@...glegroups.com, 
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Subject: Re: [syzbot] [crypto?] KASAN: slab-use-after-free Read in handle_mm_fault

Hi Suren,

On Thu, Jul 18, 2024 at 6:49 PM Suren Baghdasaryan <surenb@...gle.com> wrote:
> > > Warning: It is no longer safe to dereference vma-> after this point, because mmap_lock is dropped, so vma might be destroyed from underneath us.
>
> Better but I would change "mmap_lock is dropped" to "mmap_lock might
> have been dropped by __handle_mm_fault()" because mmap_lock is not
> always dropped by __handle_mm_fault(). Technicality but better be
> clear about it.
> With that changed feel free to add:
>
> Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>

Will do.

Thanks,
Jason