linux-kernel - Re: [PATCH] execve: Move KUnit tests to tests/ subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240718174601.64851-1-sj@kernel.org>
Date: Thu, 18 Jul 2024 10:46:01 -0700
From: SeongJae Park <sj@...nel.org>
To: David Gow <davidgow@...gle.com>
Cc: SeongJae Park <sj@...nel.org>,
	Kees Cook <kees@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>,
	Jan Kara <jack@...e.cz>,
	Eric Biederman <ebiederm@...ssion.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] execve: Move KUnit tests to tests/ subdirectory

On Thu, 18 Jul 2024 14:04:14 +0800 David Gow <davidgow@...gle.com> wrote:

> On Thu, 18 Jul 2024 at 05:22, Kees Cook <kees@...nel.org> wrote:
> >
> > Move the exec KUnit tests into a separate directory to avoid polluting
> > the local directory namespace. Additionally update MAINTAINERS for the
> > new files and mark myself as Maintainer.
> >
> > Signed-off-by: Kees Cook <kees@...nel.org>
> > ---
> > I'll toss this into -next and send it to Linus before -rc1 closes.
> > ---
> 
> With s/_test/_kunit (once the docs changes are sorted), this looks good.

I have no strong opinion, but I agree to David's rationale [1] on preferrence
of _kunit overall, and would prefer having a consistent and simple rule.

[1] https://lore.kernel.org/CABVgOS=B29PcKyhVXtTk47k_BhjSaoxL8eF15fVhzty_0syeSQ@mail.gmail.com

> 
> Reviewed-by: David Gow <davidgow@...gle.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]