linux-kernel - Re: [PATCH] init/Kconfig: remove CONFIG_GCC_ASM_GOTO_OUTPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjQVVXx=vu5O3MxcscKKujvjUZebfUG-QuOkBV1GrnDqg@mail.gmail.com>
Date: Thu, 18 Jul 2024 10:59:16 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-kernel@...r.kernel.org, alex.coplan@....com, catalin.marinas@....com, 
	jakub@....gnu.org, linux-arm-kernel@...ts.infradead.org, peterz@...radead.org, 
	seanjc@...gle.com, szabolcs.nagy@....com, will@...nel.org
Subject: Re: [PATCH] init/Kconfig: remove CONFIG_GCC_ASM_GOTO_OUTPUT_WORKAROUND

On Thu, 18 Jul 2024 at 09:59, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Let's keep the "which gcc versions are scrogged" as a separate config
> entry, and then have this just as a
>
>      default n if CC_IS_GCC && GCC_NO_ASM_GOTO_OUTPUTS

Ok, I ended up playing around with this a bit more, and it ended up like

  config GCC_ASM_GOTO_OUTPUT_BROKEN
        bool
        depends on CC_IS_GCC
        default y if GCC_VERSION < 110500
        ..

with then CC_HAS_ASM_GOTO_OUTPUT just having a

        depends on !GCC_ASM_GOTO_OUTPUT_BROKEN

in it. That looks fairly legible to me, and seems to work fine.

I left it all credited to you, since you found all the problems and
wrote that big nice commit log. But it means that if I screwed up in
my edits, you get the blame too. So if that happens, just point haters
at this email and say it's all my fault.

           Linus