linux-kernel - Re: [PATCH] i3c: master: svc: Fix error code in svc_i3c_master_do_daa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zplg4heiWF9G0ACq@lizhi-Precision-Tower-5810>
Date: Thu, 18 Jul 2024 14:37:22 -0400
From: Frank Li <Frank.li@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
	Conor Culhane <conor.culhane@...vaco.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] i3c: master: svc: Fix error code in
 svc_i3c_master_do_daa_locked()

On Thu, Jul 18, 2024 at 01:30:22PM -0500, Dan Carpenter wrote:
> This code has a typo so it returns positive EIO instead of negative -EIO.  Fix
> it!
> 
> Fixes: a7809cb368b9 ("i3c: master: svc: Improve DAA STOP handle code logic")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/i3c/master/svc-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e80c002991f7..0a68fd1b81d4 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -874,7 +874,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
>  				 * address this time.
>  				 */
>  				if (prov_id[dev_nb] == nacking_prov_id) {
> -					ret = EIO;
> +					ret = -EIO;
>  					break;
>  				}
>  
> -- 
> 2.43.0
>