linux-kernel - Re: [PATCH v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d63e56d7-368f-42ec-bcee-605289c974cb@lunn.ch>
Date: Thu, 18 Jul 2024 04:06:46 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Michal Rostecki <vadorovsky@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Wedson Almeida Filho <wedsonaf@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...sung.com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Brendan Higgins <brendan.higgins@...ux.dev>,
	David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Trevor Gross <tmgross@...ch.edu>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Martin Rodriguez Reboredo <yakoyoku@...il.com>,
	Manmohan Shukla <manmshuk@...il.com>,
	Valentin Obst <kernel@...entinobst.de>,
	Yutaro Ohno <yutaro.ono.418@...il.com>,
	Danilo Krummrich <dakr@...hat.com>,
	Charalampos Mitrodimas <charmitro@...teo.net>,
	Ben Gooding <ben.gooding.dev@...il.com>, Tejun Heo <tj@...nel.org>,
	Nell Shamrell-Harrington <nells@...ux.microsoft.com>,
	Roland Xu <mu001999@...look.com>, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	kunit-dev@...glegroups.com, netdev@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH v5] rust: str: Use `core::CStr`, remove the custom `CStr`
 implementation

> v3 -> v4:
> - Provide the `CStrExt` trait with `display()` method, which returns a
>   `CStrDisplay` wrapper with `Display` implementation. This addresses
>   the lack of `Display` implementation for `core::ffi::CStr`.
> - Provide `from_bytes_with_nul_unchecked_mut()` method in `CStrExt`,
>   which might be useful and is going to prevent manual, unsafe casts.
> - Fix a typo (s/preffered/prefered/).
> 
> v4 -> v5:
> - Keep the `test_cstr_display*` unit tests.

Please take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

In particular, the bit about 24 hours, and the merge window.

Thanks
    Andrew

---
pw-bot: cr