linux-kernel - Re: [PATCH v4 1/2] hwmon: add GPD devices sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202407190547.V7oIPiBV-lkp@intel.com>
Date: Fri, 19 Jul 2024 05:30:22 +0800
From: kernel test robot <lkp@...el.com>
To: Cryolitia PukNgae via B4 Relay <devnull+Cryolitia.gmail.com@...nel.org>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Cryolitia PukNgae <Cryolitia@...il.com>,
	Jonathan Corbet <corbet@....net>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
	linux-doc@...r.kernel.org, Celeste Liu <CoelacanthusHex@...il.com>,
	Yao Zi <ziyao@...root.org>,
	Marcin Strągowski <marcin@...agowski.com>
Subject: Re: [PATCH v4 1/2] hwmon: add GPD devices sensor driver

Hi Cryolitia,

kernel test robot noticed the following build errors:

[auto build test ERROR on d67978318827d06f1c0fa4c31343a279e9df6fde]

url:    https://github.com/intel-lab-lkp/linux/commits/Cryolitia-PukNgae-via-B4-Relay/hwmon-add-GPD-devices-sensor-driver/20240718-104420
base:   d67978318827d06f1c0fa4c31343a279e9df6fde
patch link:    https://lore.kernel.org/r/20240718-gpd_fan-v4-1-116e5431a9fe%40gmail.com
patch subject: [PATCH v4 1/2] hwmon: add GPD devices sensor driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240719/202407190547.V7oIPiBV-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240719/202407190547.V7oIPiBV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407190547.V7oIPiBV-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/hwmon/gpd-fan.c:153:18: error: initializing 'void *' with an expression of type 'const struct gpd_model_quirk *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
     153 |                 .driver_data    = &gpd_win_mini_quirk,
         |                                   ^~~~~~~~~~~~~~~~~~~
   drivers/hwmon/gpd-fan.c:162:18: error: initializing 'void *' with an expression of type 'const struct gpd_model_quirk *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
     162 |                 .driver_data    = &gpd_win4_quirk,
         |                                   ^~~~~~~~~~~~~~~
   drivers/hwmon/gpd-fan.c:171:18: error: initializing 'void *' with an expression of type 'const struct gpd_model_quirk *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
     171 |                 .driver_data    = &gpd_wm2_quirk,
         |                                   ^~~~~~~~~~~~~~
   drivers/hwmon/gpd-fan.c:181:18: error: initializing 'void *' with an expression of type 'const struct gpd_model_quirk *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
     181 |                 .driver_data    = &gpd_wm2_quirk,
         |                                   ^~~~~~~~~~~~~~
>> drivers/hwmon/gpd-fan.c:496:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     496 |                         s32 ret = data->quirk->read_rpm(data);
         |                         ^
   drivers/hwmon/gpd-fan.c:513:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     513 |                         s16 ret = data->quirk->read_pwm(data);
         |                         ^
   drivers/hwmon/gpd-fan.c:541:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     541 |                         u8 var = clamp_val(val, 0, 255);
         |                         ^
   3 warnings and 4 errors generated.


vim +153 drivers/hwmon/gpd-fan.c

   144	
   145	static const struct dmi_system_id gpd_devices[] = {
   146		{
   147			// GPD Win Mini
   148			// GPD Win Mini with AMD Ryzen 8840U
   149			.matches	= {
   150						DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
   151						DMI_MATCH(DMI_PRODUCT_NAME, "G1617-01")
   152					},
 > 153			.driver_data	= &gpd_win_mini_quirk,
   154		},
   155		{
   156			// GPD Win 4 with AMD Ryzen 6800U
   157			.matches	= {
   158						DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
   159						DMI_MATCH(DMI_PRODUCT_NAME, "G1618-04"),
   160						DMI_MATCH(DMI_BOARD_VERSION, "Default string"),
   161					},
 > 162			.driver_data	= &gpd_win4_quirk,
   163		},
   164		{
   165			// GPD Win 4 with Ryzen 7840U
   166			.matches	= {
   167						DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
   168						DMI_MATCH(DMI_PRODUCT_NAME, "G1618-04"),
   169						DMI_MATCH(DMI_BOARD_VERSION, "Ver. 1.0"),
   170					},
   171			.driver_data	= &gpd_wm2_quirk,
   172		},
   173		{
   174			// GPD Win Max 2 with Ryzen 6800U
   175			// GPD Win Max 2 2023 with Ryzen 7840U
   176			// GPD Win Max 2 2024 with Ryzen 8840U
   177			.matches	= {
   178						DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
   179						DMI_MATCH(DMI_PRODUCT_NAME, "G1619-04"),
   180					},
   181			.driver_data	= &gpd_wm2_quirk,
   182		},
   183		{}
   184	};
   185	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki