linux-kernel - Re: [PATCH -fixes] riscv: cpufeature: Do not drop Linux-internal extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75ba30e5-3371-4ca9-9dbd-af7f78907c30@sifive.com>
Date: Thu, 18 Jul 2024 16:34:39 -0500
From: Samuel Holland <samuel.holland@...ive.com>
To: Palmer Dabbelt <palmer@...belt.com>, linux-riscv@...ts.infradead.org
Cc: Albert Ou <aou@...s.berkeley.edu>, Andrew Jones
 <ajones@...tanamicro.com>, Andy Chiu <andy.chiu@...ive.com>,
 Charlie Jenkins <charlie@...osinc.com>, Clément Léger
 <cleger@...osinc.com>, Conor Dooley <conor@...nel.org>,
 Evan Green <evan@...osinc.com>, Paul Walmsley <paul.walmsley@...ive.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH -fixes] riscv: cpufeature: Do not drop Linux-internal
 extensions

On 2024-07-18 4:29 PM, Samuel Holland wrote:
> The Linux-internal Xlinuxenvcfg ISA extension is omitted from the
> riscv_isa_ext array because it has no DT binding and should not appear
> in /proc/cpuinfo. The logic added in commit 625034abd52a ("riscv: add
> ISA extensions validation callback") assumes all extensions are included
> in riscv_isa_ext, and so riscv_resolve_isa() wrongly drops Xlinuxenvcfg
> from the final ISA string. Instead, accept such Linux-internal ISA
> extensions as if they have no validation callback.
> 
> Fixes: 625034abd52a ("riscv: add ISA extensions validation callback")

Apologies for the incorrect subject line. This fixes a commit in for-next, so
this patch is targeting for-next.

> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> ---
> 
>  arch/riscv/kernel/cpufeature.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)