linux-kernel - Re: [PATCH v2 1/3] blk-cgroup: check for pd_(alloc|free)_fn in blkcg_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zpn5zvcC4TbDxeKU@infradead.org>
Date: Thu, 18 Jul 2024 22:29:50 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: bvanassche@....org, jack@...e.cz, hch@...radead.org, tj@...nel.org,
	josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 1/3] blk-cgroup: check for pd_(alloc|free)_fn in
 blkcg_activate_policy()

On Fri, Jul 19, 2024 at 10:34:29AM +0800, Yu Kuai wrote:
> +	/*
> +	 * Make sure cpd/pd_alloc_fn and cpd/pd_free_fn in pairs, and policy
> +	 * without pd_alloc_fn/pd_free_fn can't be activated.
> +	 */
>  	if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) ||
>  		(!pol->pd_alloc_fn ^ !pol->pd_free_fn))
>  		goto err_unlock;
> -- 

I know this is existing code, but can you fix up the incorrect
indentation while you touch this:

 	if ((!pol->cpd_alloc_fn ^ !pol->cpd_free_fn) ||
 	    (!pol->pd_alloc_fn ^ !pol->pd_free_fn))

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>