linux-kernel - Re: [PATCH] arm64: qcom: don't select HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Me3SWwh6aS=0c7tD0EeA=Wxs8Y6e-ZREvJErHdPdJBKuA@mail.gmail.com>
Date: Fri, 19 Jul 2024 09:51:53 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jeff Johnson <quic_jjohnson@...cinc.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Arnd Bergmann <arnd@...db.de>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n

On Fri, Jul 19, 2024 at 9:28 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The new HAVE_PWRCTL option is defined in the PCI subsystem, so
> selecting it unconditionally when PCI is disabled causes a harmless
> warning:
>
> WARNING: unmet direct dependencies detected for HAVE_PWRCTL
>   Depends on [n]: PCI [=n]
>   Selected by [y]:
>   - ARCH_QCOM [=y]
>
> Add 'if PCI' in the qualcomm platform to hide the warning.
>
> Fixes: ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm64/Kconfig.platforms | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 9b62c63781ec..6c6d11536b42 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -266,7 +266,7 @@ config ARCH_QCOM
>         bool "Qualcomm Platforms"
>         select GPIOLIB
>         select PINCTRL
> -       select HAVE_PWRCTL
> +       select HAVE_PWRCTL if PCI
>         help
>           This enables support for the ARMv8 based Qualcomm chipsets.
>
> --
> 2.39.2
>
>

I applied it manually. For some reason b4 cannot grab this from lore.

Bartosz