linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7edb3361-9e53-44ad-82ec-b2c81834b2ea@collabora.com>
Date: Fri, 19 Jul 2024 11:21:58 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Fei Shao <fshao@...omium.org>, Chen-Yu Tsai <wenst@...omium.org>
Cc: Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP
 reserved memory region

Il 19/07/24 06:58, Fei Shao ha scritto:
> Corsola firmware reserves the memory region of [0x60000000, 0x61100000)

Sorry but if the region is supposed to be 0x1100000 long....

> exclusively for ADSP usage.
> But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
> assigned to the ADSP node in the Corsola device tree, meaning no audio
> tasks can access and utilize that memory section.
> 
> Update the reserved ADSP memory region to fill the gap.
> 
> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> Signed-off-by: Fei Shao <fshao@...omium.org>
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> index afdab5724eaa..0c4a26117428 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> @@ -169,7 +169,7 @@ adsp_dma_mem: memory@...00000 {
>   
>   		adsp_mem: memory@...00000 {
>   			compatible = "shared-dma-pool";
> -			reg = <0 0x60000000 0 0xA00000>;
> +			reg = <0 0x60000000 0 0x1000000>;

...why are you making it 0x1000000 long?

Cheers,
Angelo

>   			no-map;
>   		};
>