linux-kernel - Re: [PATCH] mailbox: qcom-cpucp: fix 64BIT dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3381f68-35e6-42b2-9628-e0da44374f53@linaro.org>
Date: Fri, 19 Jul 2024 12:04:16 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>, Jassi Brar <jassisinghbrar@...il.com>,
 Sibi Sankar <quic_sibis@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: qcom-cpucp: fix 64BIT dependency

On 19.07.2024 12:02 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This newly added driver fails compile testing on 32-bit architectures
> because it relies on 64-bit MMIO register access:
> 
> drivers/mailbox/qcom-cpucp-mbox.c: In function 'qcom_cpucp_mbox_irq_fn':
> drivers/mailbox/qcom-cpucp-mbox.c:54:18: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Wimplicit-function-declaration]
>    54 |         status = readq(cpucp->rx_base + APSS_CPUCP_RX_MBOX_STAT);
>       |                  ^~~~~
>       |                  readb
> drivers/mailbox/qcom-cpucp-mbox.c:65:17: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Wimplicit-function-declaration]
>    65 |                 writeq(BIT(i), cpucp->rx_base + APSS_CPUCP_RX_MBOX_CLEAR);
>       |                 ^~~~~~
>       |                 writeb
> 
> Change the Kconfig dependency to disallow that configuration as well.
> 
> Fixes: 0e2a9a03106c ("mailbox: Add support for QTI CPUCP mailbox controller")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad