linux-kernel - Re: [PATCH 2/2] coda: support FSCONFIG_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240719.012054-sad.combo.frozen.vibe-iRGqBcI4zDQb@cyphar.com>
Date: Fri, 19 Jul 2024 11:21:31 +1000
From: Aleksa Sarai <cyphar@...har.com>
To: kernel test robot <lkp@...el.com>
Cc: Ian Kent <raven@...maw.net>, Bill O'Donnell <bodonnel@...hat.com>, 
	Christian Brauner <brauner@...nel.org>, Jan Harkes <jaharkes@...cmu.edu>, coda@...cmu.edu, 
	Eric Sandeen <sandeen@...hat.com>, David Howells <dhowells@...hat.com>, 
	oe-kbuild-all@...ts.linux.dev, autofs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	codalist@...a.cs.cmu.edu
Subject: Re: [PATCH 2/2] coda: support FSCONFIG_SET_FD for fd mount flag

On 2024-07-19, kernel test robot <lkp@...el.com> wrote:
> Hi Aleksa,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on b80cc4df1124702c600fd43b784e423a30919204]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Aleksa-Sarai/autofs-fix-missing-fput-for-FSCONFIG_SET_FD/20240718-230056
> base:   b80cc4df1124702c600fd43b784e423a30919204
> patch link:    https://lore.kernel.org/r/20240719-fsconfig-fsparam_fd-fixes-v1-2-7ccd315c2ad4%40cyphar.com
> patch subject: [PATCH 2/2] coda: support FSCONFIG_SET_FD for fd mount flag
> config: arm-randconfig-003-20240719 (https://download.01.org/0day-ci/archive/20240719/202407190741.8fA9KJbt-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240719/202407190741.8fA9KJbt-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407190741.8fA9KJbt-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    fs/coda/inode.c: In function 'coda_parse_fd':
> >> fs/coda/inode.c:129:13: error: 'param' undeclared (first use in this function); did you mean 'parameq'?
>      129 |         if (param->type == fs_value_is_file) {
>          |             ^~~~~
>          |             parameq
>    fs/coda/inode.c:129:13: note: each undeclared identifier is reported only once for each function it appears in
> >> fs/coda/inode.c:133:29: error: 'result' undeclared (first use in this function); did you mean 'mf_result'?
>      133 |                 file = fget(result->uint_32);
>          |                             ^~~~~~
>          |                             mf_result

D'oh. I compile tested it but this fs wasn't enabled in my config...

My bad.

> vim +129 fs/coda/inode.c
> 
>    121	
>    122	static int coda_parse_fd(struct fs_context *fc, int fd)
>    123	{
>    124		struct coda_fs_context *ctx = fc->fs_private;
>    125		struct file *file;
>    126		struct inode *inode;
>    127		int idx;
>    128	
>  > 129		if (param->type == fs_value_is_file) {
>    130			file = param->file;
>    131			param->file = NULL;
>    132		} else {
>  > 133			file = fget(result->uint_32);
>    134		}
>    135		if (!file)
>    136			return -EBADF;
>    137	
>    138		inode = file_inode(file);
>    139		if (!S_ISCHR(inode->i_mode) || imajor(inode) != CODA_PSDEV_MAJOR) {
>    140			fput(file);
>    141			return invalf(fc, "code: Not coda psdev");
>    142		}
>    143	
>    144		idx = iminor(inode);
>    145		fput(file);
>    146	
>    147		if (idx < 0 || idx >= MAX_CODADEVS)
>    148			return invalf(fc, "coda: Bad minor number");
>    149		ctx->idx = idx;
>    150		return 0;
>    151	}
>    152	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)