linux-kernel - RE: [PATCH] gpio: vf610: always set GPIO to input mode when used as interrupt source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9496F701AE831C2DEDA6205390AD2@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Fri, 19 Jul 2024 01:46:36 +0000
From: Bough Chen <haibo.chen@....com>
To: Stefan Wahren <wahrenst@....net>
CC: Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij
	<linus.walleij@...aro.org>, "open list:GPIO SUBSYSTEM"
	<linux-gpio@...r.kernel.org>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH] gpio: vf610: always set GPIO to input mode when used as
 interrupt source

> -----Original Message-----
> From: Stefan Wahren <wahrenst@....net>
> Sent: 2024年7月19日 1:09
> To: Bough Chen <haibo.chen@....com>
> Cc: Bartosz Golaszewski <brgl@...ev.pl>; Linus Walleij
> <linus.walleij@...aro.org>; open list:GPIO SUBSYSTEM
> <linux-gpio@...r.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; imx@...ts.linux.dev
> Subject: Re: [PATCH] gpio: vf610: always set GPIO to input mode when used as
> interrupt source
> 
> Hi,
> 
> I found this thread about the vf610 driver, because I noticed today that the
> i.MX93 is missing the GPIO get_direction callback.

I find the patch was wrong, we can't call gc.direction_input in vf610_gpio_irq_set_type(), because gc.direction_input will call pinctrl_gpio_direction_input(), this API can't be used in irq context. 

For get_direction callback, yes, I will send a patch this week.

Best Regards
Haibo Chen
> 
> Are there any plans to implement this?
> 
> Best regards