linux-kernel - Re: [PATCH] HID: core: Fix parsing error for Thinkbook16 G6+ IMH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <uwn4lccc34xtilwzfbogjor2xrue6ob7ydlywaylvg4a53x7io@bq4nqnkczu4s>
Date: Fri, 19 Jul 2024 16:01:01 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: 艾超 <aichao@...inos.cn>
Cc: jikos <jikos@...nel.org>, linux-input <linux-input@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: core: Fix parsing error for Thinkbook16 G6+ IMH

Hi,

Thanks for your contribution but there are many things wrong with your
patch submission:
- you used html which should be rejected by the mailing list
- your mail client completely messed up the format and the patch is not
  applicable in its current state.
- your signed-off-by is not correct as it's missing your email.

Please make sure to use `git send-email` or `b4` for your future
submissions

Also, the patch in itself (or what I could guess on the email I
received) is wrong. You should not tamper with hid-core for that but
need a dedicated report descriptor fixup in the target driver.

However, the device seems to rely on hid-multitouch which I'd rather not
have report descriptor fixups in there.

Maybe the simplest solution is to rely on HID-BPF and submit a new
driver fix to https://gitlab.freedesktop.org/libevdev/udev-hid-bpf or if
you want to directly submit said fix to the kernel in the directory
drivers/hid/bpf/progs.

Cheers,
Benjamin

On Jul 19 2024, 艾超 wrote: