linux-kernel - Re: [PATCH] sunrpc: avoid -Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zppze/qB2m9O0MH4@tissot.1015granger.net>
Date: Fri, 19 Jul 2024 10:08:59 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jeff Layton <jlayton@...nel.org>, Trond Myklebust <trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Neil Brown <neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>,
        Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Benjamin Coddington <bcodding@...hat.com>,
        Josef Bacik <josef@...icpanda.com>, linux-nfs@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sunrpc: avoid -Wformat-security warning

On Fri, Jul 19, 2024 at 12:54:22PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Using a non-constant string as an sprintf-style is potentially dangerous:
> 
> net/sunrpc/svc.c: In function 'param_get_pool_mode':
> net/sunrpc/svc.c:164:32: error: format not a string literal and no format arguments [-Werror=format-security]
> 
> Use a literal "%s" format instead.
> 
> Fixes: 5f71f3c32553 ("sunrpc: refactor pool_mode setting code")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/sunrpc/svc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index e03f14024e47..88a59cfa5583 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -161,7 +161,7 @@ param_get_pool_mode(char *buf, const struct kernel_param *kp)
>  	str[len] = '\n';
>  	str[len + 1] = '\0';
>  
> -	return sysfs_emit(buf, str);
> +	return sysfs_emit(buf, "%s", str);
>  }
>  
>  module_param_call(pool_mode, param_set_pool_mode, param_get_pool_mode,
> -- 
> 2.39.2
> 

Applied to nfsd-fixes (for v6.11-rc). Thanks!

-- 
Chuck Lever