linux-kernel - Re: [PATCH v1] x86/amd_nb: Add new PCI IDs for AMD family 0x1a model 60h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240719142803.GB17507@yaz-khff2.amd.com>
Date: Fri, 19 Jul 2024 10:28:03 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Bjorn Helgaas <helgaas@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Anvin <hpa@...or.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Muralidhara M K <muralidhara.mk@....com>,
	Avadhut Naik <Avadhut.Naik@....com>,
	Mario Limonciello <mario.limonciello@....com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH v1] x86/amd_nb: Add new PCI IDs for AMD family 0x1a model
 60h

On Thu, Jul 18, 2024 at 11:37:31PM +0530, Shyam Sundar S K wrote:
> 
> 
> On 7/18/2024 22:43, Bjorn Helgaas wrote:
> > On Thu, Jul 18, 2024 at 07:32:58PM +0530, Shyam Sundar S K wrote:
> >> Add the new PCI Device IDs to the root IDs and misc ids list to support
> >> new generation of AMD 1Ah family 60h Models of processors.
> >>
> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> >> ---
> >> (As the amd_nb functions are used by PMC and PMF drivers, without these IDs
> >> being present AMD PMF/PMC probe shall fail.)
> > 
> > Is there any plan for making this generic so a kernel update is not
> > needed?  Obviously the *functionality* is not changed by this patch,
> > so having to add a device ID for every new processor just makes work
> > for distros and users.
> 
> Regarding AMD processors, there are numerous PCI IDs defined in the
> PPRs/BKDG. I'm not sure if there's a generic way to address this
> without a kernel update.
>

One of our colleagues is working on a possible solution. It'll likely
use device types and class codes so we don't need to add individual PCI
IDs for each new product.

Thanks,
Yazen