linux-kernel - Re: [PATCH] [v2] gpio: virtuser: avoid non-constant format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172140109528.139764.1997443396332853714.b4-ty@linaro.org>
Date: Fri, 19 Jul 2024 16:58:18 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Arnd Bergmann <arnd@...nel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] gpio: virtuser: avoid non-constant format string

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Fri, 19 Jul 2024 16:44:10 +0200, Arnd Bergmann wrote:
> Using a string variable as an sprintf format is potentially
> dangerous, and gcc can warn about this:
> 
> drivers/gpio/gpio-virtuser.c: In function 'gpio_virtuser_dbgfs_init_line_attrs':
> drivers/gpio/gpio-virtuser.c:808:9: error: format not a string literal and no format arguments [-Werror=format-security]
>   808 |         sprintf(data->consumer, id);
>       |         ^~~~~~~
> 
> [...]

Applied, thanks!

[1/1] gpio: virtuser: avoid non-constant format string
      commit: 3ae08e47742eeebf2190900d31ddac53fdd13a5b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>