linux-kernel - Re: [PATCH] sound: hda: tas2781: mark const variables as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734o5s6ui.wl-tiwai@suse.de>
Date: Fri, 19 Jul 2024 18:07:49 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Arnd Bergmann <arnd@...db.de>,
	Gergo Koteles <soyer@....hu>,
	Mark Brown <broonie@...nel.org>,
	alsa-devel@...a-project.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: hda: tas2781: mark const variables as __maybe_unused

On Fri, 19 Jul 2024 11:56:34 +0200,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> An earlier patch changed the DECLARE_TLV_DB_SCALE declaration, but
> now there are additional static const variables that cause
> the same build warnings:
> 
> In file included from sound/pci/hda/tas2781_hda_i2c.c:23:
> include/sound/tas2781-tlv.h:23:28: error: 'tas2563_dvc_table' defined but not used [-Werror=unused-const-variable=]
>    23 | static const unsigned char tas2563_dvc_table[][4] = {
>       |                            ^~~~~~~~~~~~~~~~~
> In file included from include/sound/tlv.h:10,
>                  from sound/pci/hda/tas2781_hda_i2c.c:22:
> include/sound/tas2781-tlv.h:20:35: error: 'tas2563_dvc_tlv' defined but not used [-Werror=unused-const-variable=]
>    20 | static const DECLARE_TLV_DB_SCALE(tas2563_dvc_tlv, -12150, 50, 1);
>       |                                   ^~~~~~~~~~~~~~~
> 
> Mark them all as unused as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied now.


Takashi