linux-kernel - Re: [PATCH v2 2/3] crypto: X25519 core functions for ppc64le

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e27ccb59-0a3b-4845-bec4-f64830b2492e@quicinc.com>
Date: Thu, 18 Jul 2024 17:25:08 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Danny Tsen <dtsen@...ux.ibm.com>, <linux-crypto@...r.kernel.org>
CC: <herbert@...dor.apana.org.au>, <leitao@...ian.org>, <nayna@...ux.ibm.com>,
        <appro@...ptogams.org>, <linux-kernel@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <mpe@...erman.id.au>,
        <ltcgcw@...ux.vnet.ibm.com>, <dtsen@...ibm.com>
Subject: Re: [PATCH v2 2/3] crypto: X25519 core functions for ppc64le

On 5/16/24 08:19, Danny Tsen wrote:
> X25519 core functions to handle scalar multiplication for ppc64le.
> 
> Signed-off-by: Danny Tsen <dtsen@...ux.ibm.com>
> ---
>   arch/powerpc/crypto/curve25519-ppc64le-core.c | 299 ++++++++++++++++++
>   1 file changed, 299 insertions(+)
>   create mode 100644 arch/powerpc/crypto/curve25519-ppc64le-core.c
...

> +MODULE_ALIAS_CRYPTO("curve25519");
> +MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Danny Tsen <dtsen@...ibm.com>");

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. I'm in the process of building 
ppc64le with CRYPTO_CURVE25519_PPC64=m to validate my suspicion, but I 
expect this to generate a warning.

Can you submit a follow-up patch that adds a MODULE_DESCRIPTION()?
And since I'm trying to fix all of the existing issues in 6.11, Herbert 
can you push this to Linus when it lands?

Thanks,
/jeff