linux-kernel - Re: [PATCH] btrfs: change mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240719160733.GA23446@twin.jikos.cz>
Date: Fri, 19 Jul 2024 18:07:33 +0200
From: David Sterba <dsterba@...e.cz>
To: David Sterba <dsterba@...e.cz>
Cc: Arnd Bergmann <arnd@...nel.org>, Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
	Qu Wenruo <wqu@...e.com>, Arnd Bergmann <arnd@...db.de>,
	Filipe Manana <fdmanana@...e.com>,
	Johannes Thumshirn <johannes.thumshirn@....com>,
	Anand Jain <anand.jain@...cle.com>,
	Christian Brauner <brauner@...nel.org>,
	Naohiro Aota <naohiro.aota@....com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: change mount_opt to u64

On Fri, Jul 19, 2024 at 03:24:54PM +0200, David Sterba wrote:
> On Fri, Jul 19, 2024 at 12:37:06PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > The newly added BTRFS_MOUNT_IGNORESUPERFLAGS flag does not fit into a 32-bit
> > flags word, as shown by this warning on 32-bit architectures:
> > 
> > fs/btrfs/super.c: In function 'btrfs_check_options':
> > fs/btrfs/super.c:666:48: error: conversion from 'enum <anonymous>' to 'long unsigned int' changes value from '4294967296' to '0' [-Werror=overflow]
> >   666 |              check_ro_option(info, *mount_opt, BTRFS_MOUNT_IGNORESUPERFLAGS, "ignoresuperflags")))
> >       |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Change all interfaces that deal with mount flags to use a 64-bit type
> > on all architectures instead.
> > 
> > Fixes: 32e6216512b4 ("btrfs: introduce new "rescue=ignoresuperflags" mount option")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ----
> > Please double-check that I got all the instances. I only looked at where the
> > obvious users are, but did not actually try to run this on a 32-bit target
> 
> Thanks, the build issue is known and fix will be sent in 2nd pull
> reuqest on Monday.
             ^^^^^^

I'll send the pull request rather today.