linux-kernel - Re: [PATCH v3] vmstat: Kernel stack usage histogram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bAWRN7-UHc0C1u6UAqT82tQXgO6a4AnHEHWN-qqij1LQQ@mail.gmail.com>
Date: Thu, 18 Jul 2024 22:56:14 -0400
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: akpm@...ux-foundation.org, jpoimboe@...nel.org, kent.overstreet@...ux.dev, 
	peterz@...radead.org, nphamcs@...il.com, cerasuolodomenico@...il.com, 
	surenb@...gle.com, lizhijian@...itsu.com, willy@...radead.org, vbabka@...e.cz, 
	ziy@...dia.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram

On Thu, Jul 18, 2024 at 7:19 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
>
> Hi Pasha,
>
> On Wed, Jul 17, 2024 at 12:50:00PM GMT, Pasha Tatashin wrote:
> > On Wed, Jun 12, 2024 at 2:50 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
> > >
> [...]
> > > >
> > > > One more question: Is there any concern in making
> > > > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default
> > > > kernels instead of just debug kernels?
> >
> > We enabled it in Google ProdKernel. There is some overhead when
> > threads are exiting, because we are looking for the first non-zero
> > byte, but that is minimal. We haven't observed any performance impact
> > on our fleet.
> >
>
> So, you would support making CONFIG_DEBUG_STACK_USAGE enabled by
> default, right?

Right, I see nothing wrong with having this enabled by default.

Pasha