linux-kernel - Re: [PATCH 02/10] accel/amdxdna: Support hardware mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198384d7-23a6-4866-9f22-3aac028e0ee0@web.de>
Date: Fri, 19 Jul 2024 22:04:52 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: George Yang <George.Yang@....com>, Lizhi Hou <lizhi.hou@....com>,
 Min Ma <min.ma@....com>, Narendra Gutta
 <VenkataNarendraKumar.Gutta@....com>, dri-devel@...ts.freedesktop.org,
 Oded Gabbay <ogabbay@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Max Zhen <max.zhen@....com>,
 Sonal Santan <sonal.santan@....com>
Subject: Re: [PATCH 02/10] accel/amdxdna: Support hardware mailbox

…
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -0,0 +1,582 @@
…
> +static int mailbox_acquire_msgid(struct mailbox_channel *mb_chann, struct mailbox_msg *mb_msg)
> +{
…
> +	spin_lock_irqsave(&mb_chann->chan_idr_lock, flags);
> +	msg_id = idr_alloc_cyclic(&mb_chann->chan_idr, mb_msg, 0,
> +				  MAX_MSG_ID_ENTRIES, GFP_NOWAIT);
> +	spin_unlock_irqrestore(&mb_chann->chan_idr_lock, flags);
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&mb_chann->chan_idr_lock);”?
https://elixir.bootlin.com/linux/v6.10/source/include/linux/spinlock.h#L574

Regards,
Markus