[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <717a8269-95f5-4aae-913b-0108c6dac70e@web.de>
Date: Fri, 19 Jul 2024 22:33:55 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: George Yang <George.Yang@....com>, Lizhi Hou <lizhi.hou@....com>,
Min Ma <min.ma@....com>, Narendra Gutta
<VenkataNarendraKumar.Gutta@....com>, dri-devel@...ts.freedesktop.org,
Oded Gabbay <ogabbay@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Max Zhen <max.zhen@....com>,
Sonal Santan <sonal.santan@....com>
Subject: Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine
…
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -0,0 +1,182 @@
…
> +static int aie2_init(struct amdxdna_dev *xdna)
> +{
…
> + release_firmware(fw);
> + return 0;
I find the following statements more appropriate here
(so that a bit of redundant code can be avoided).
ret = 0;
goto release_fw;
…
> +release_fw:
> + release_firmware(fw);
> +
> + return ret;
> +}
…
Regards,
Markus
Powered by blists - more mailing lists