linux-kernel - Re: [PATCH 03/10] accel/amdxdna: Add hardware resource solver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b90c3712-4651-40ec-9826-ac0d620d2fb8@web.de>
Date: Sat, 20 Jul 2024 11:15:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Lizhi Hou <lizhi.hou@....com>, Min Ma <min.ma@....com>,
 dri-devel@...ts.freedesktop.org, Oded Gabbay <ogabbay@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Max Zhen <max.zhen@....com>,
 Sonal Santan <sonal.santan@....com>
Subject: Re: [PATCH 03/10] accel/amdxdna: Add hardware resource solver

> The AI Engine consists of 2D array of tiles arranged as columns. The
> resource solver provides the interfaces to manage allocation of the tile
> columns for a hardware context. The basic column allocation and release
> functions are provided.

Can such a change description be improved with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94

…
> +++ b/drivers/accel/amdxdna/aie2_solver.c
> @@ -0,0 +1,329 @@
…
> +void *xrsm_init(struct init_config *cfg)
> +{
…
> +	memcpy(&xrs->cfg, cfg, sizeof(struct init_config));
…

Please specify a pointer “dereference” instead of the data structure name.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10#n953

Regards,
Markus