linux-kernel - Re: [PATCH v1 02/10] iio: pressure: bmp280: Fix waiting time for BMP3xx configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240720120636.38b9cdcb@jic23-huawei>
Date: Sat, 20 Jul 2024 12:06:36 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
 ang.iglesiasg@...il.com, linus.walleij@...aro.org,
 biju.das.jz@...renesas.com, javier.carrasco.cruz@...il.com,
 semen.protsenko@...aro.org, 579lpy@...il.com, ak@...klinger.de,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 02/10] iio: pressure: bmp280: Fix waiting time for
 BMP3xx configuration

On Thu, 11 Jul 2024 23:15:50 +0200
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> According to the datasheet, both pressure and temperature can go up to
> oversampling x32. With this option, the maximum measurement time is not
> 80ms (this is for press x32 and temp x2), but it is 130ms nominal
> (calculated from table 3.9.2) and since most of the maximum values
> are around +15%, it is configured to 150ms.
> 
> Fixes: 8d329309184d ("iio: pressure: bmp280: Add support for BMP380 sensor family")
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
Applied to what will be the togreg branch of iio.git and marked for stable.

If it needs to move quicker as we have reports of problems from users
let me know.

Jonathan

> ---
>  drivers/iio/pressure/bmp280-core.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index cc8553177977..3deaa57bb3f5 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -1581,10 +1581,11 @@ static int bmp380_chip_config(struct bmp280_data *data)
>  		}
>  		/*
>  		 * Waits for measurement before checking configuration error
> -		 * flag. Selected longest measure time indicated in
> -		 * section 3.9.1 in the datasheet.
> +		 * flag. Selected longest measurement time, calculated from
> +		 * formula in datasheet section 3.9.2 with an offset of ~+15%
> +		 * as it seen as well in table 3.9.1.
>  		 */
> -		msleep(80);
> +		msleep(150);
>  
>  		/* Check config error flag */
>  		ret = regmap_read(data->regmap, BMP380_REG_ERROR, &tmp);