linux-kernel - Re: [PATCH] net: stmmac: fix the mistake of the device tree property string of reset gpio in stmmac_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c5f35c1-cf3a-4759-ac17-54e6f8c22c69@lunn.ch>
Date: Sat, 20 Jul 2024 14:35:26 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Zhouyi Zhou <zhouzhouyi@...il.com>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, kuba@...nel.org,
	mcoquelin.stm32@...il.com, linus.walleij@...aro.org,
	martin.blumenstingl@...glemail.com, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	"zhili.liu" <zhili.liu@...s.com.cn>,
	wangzhiqiang <zhiqiangwang@...s.com.cn>
Subject: Re: [PATCH] net: stmmac: fix the mistake of the device tree property
 string of reset gpio in stmmac_mdio_reset

On Sat, Jul 20, 2024 at 04:00:27AM +0000, Zhouyi Zhou wrote:
> From: "zhili.liu" <zhili.liu@...s.com.cn>
> 
> According to Documentation/devicetree/bindings/net/snps,dwmac.yaml,
> the device tree property of PHY Reset GPIO should be "snps,reset-gpio".
> 
> Use string "snps,reset-gpio" instead of "snps,reset" in stmmac_mdio_reset
> when invoking devm_gpiod_get_optional.

Have you found the current code does not work on a board you have, or
is this by code inspection?

https://elixir.bootlin.com/linux/v6.10/source/drivers/gpio/gpiolib-of.c#L687
https://elixir.bootlin.com/linux/v6.10/source/drivers/gpio/gpiolib.h#L93

See how it appends -gpio and -gpios to the name.

I also randomly check a few users of devm_gpiod_get_optional() and non
of them include the -gpio in the name, leaving the GPIO core to do it.

	Andrew