linux-kernel - Re: [PATCH] iio: light: ltrf216a: Document the device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ=WyTNxoJGm-7ZRDYuKPGDSDFCoThfqv=+6b=MQn=pQw@mail.gmail.com>
Date: Sat, 20 Jul 2024 08:43:59 -0600
From: Rob Herring <robh@...nel.org>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Shreeya Patel <shreeya.patel@...labora.com>, lars@...afoo.de, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel@...labora.com, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Marek Vasut <marex@...x.de>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] iio: light: ltrf216a: Document the device name

On Sat, Jul 20, 2024 at 7:22 AM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Mon, 15 Jul 2024 01:07:09 +0530
> Shreeya Patel <shreeya.patel@...labora.com> wrote:
>
> > Compatible 'ltr,ltrf216a' is used by Valve's Steamdeck device
> > via the ACPI + PRP0001 mechanism.
> > Document the device name alognside the compatible.
> >
> > Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
> Hi Shreeya,
>
> I'm guessing you used get_maintainers for this.  Always check that there
> isn't anyone else who should be added.
>
> Given the root of this was the discussion about dropping this undocumented
> binding the DT maintainers and list should definitely be CC'd + Marek
> who was part of the earlier discussion.
>
> The fact that this isn't a typical ID from a Windows consumer device does
> change things a little, but I'd imagine a firmware update for the steamdeck
> is equally unlikely to happen in order to fix the vendor-id.
> (I was surprised to discover they provide windows drivers for it but
> not seeing the light sensor in the list)
>
> So my opinion is that we should keep this ID in place with an enhanced
> description.
>
> The other suggestion from the Krzysztof's thread was the risk of this getting
> abused.  Perhaps we should specifically fail to probe if that ID is used and
> it's not an ACPI firmware?

Use of it can now not pass validation with dtschema. IMO, that's enough.

Rob