linux-kernel - Re: [PATCH] clk: T-Head: Disable on 32-bit Targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zpv2Btw3dUXaJxp9@x1>
Date: Sat, 20 Jul 2024 10:38:14 -0700
From: Drew Fustini <drew@...7.com>
To: Palmer Dabbelt <palmer@...osinc.com>
Cc: sboyd@...nel.org, mturquette@...libre.com, jszhang@...nel.org,
	dfustini@...storrent.com, frank.li@...o.com,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: T-Head: Disable on 32-bit Targets

On Fri, Jul 19, 2024 at 08:10:27AM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@...osinc.com>
> 
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
> 
> Signed-off-by: Palmer Dabbelt <palmer@...osinc.com>
> ---
>  drivers/clk/thead/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
> index 1710d50bf9d4..95e0d9eb965e 100644
> --- a/drivers/clk/thead/Kconfig
> +++ b/drivers/clk/thead/Kconfig
> @@ -3,6 +3,7 @@
>  config CLK_THEAD_TH1520_AP
>  	bool "T-HEAD TH1520 AP clock support"
>  	depends on ARCH_THEAD || COMPILE_TEST
> +	depends on 64BIT
>  	default ARCH_THEAD
>  	select REGMAP_MMIO
>  	help
> -- 
> 2.45.2
> 

Acked-by: Drew Fustini <drew@...7.com>

Sorry about that. This patch makes sense as the TH1520 SoC is 64-bit
and I see no valid use case to run a 32-bit kernel on it.

Drew