linux-kernel - Re: [PATCH v2] loongarch: Support RANDOMIZE_KSTACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a654c7e2-929c-cbeb-cfd5-b8bbb00845d2@huawei.com>
Date: Sat, 20 Jul 2024 10:52:06 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Kees Cook <kees@...nel.org>
CC: <chenhuacai@...nel.org>, <kernel@...0n.name>, <gustavoars@...nel.org>,
	<arnd@...db.de>, <maobibo@...ngson.cn>, <loongarch@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v2] loongarch: Support RANDOMIZE_KSTACK_OFFSET



On 2024/7/20 0:01, Kees Cook wrote:
> On Fri, Jul 19, 2024 at 11:14:27AM +0800, Jinjie Ruan wrote:
>> Add support of kernel stack offset randomization while handling syscall,
>> the offset is defaultly limited by KSTACK_OFFSET_MAX().
>>
>> In order to avoid trigger stack canaries (due to __builtin_alloca) and
>> slowing down the entry path, use __no_stack_protector attribute to
>> disable stack protector for do_syscall() at function level.
>>
>> With this patch, the REPORT_STACK test show that:
>> 	`loongarch64 bits of stack entropy: 7`
> 
> I suspect this will report the correct "6" after now that this commit
> has landed:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=872bb37f6829d4f7f3ed5afe2786add3d4384b4b

Hi, Kees

I noticed your patch, and I reconfirm that I have updated to the latest
mainline and that your patch is in the code.

However，the following REPORT_STACK test of your below script has the
same result (run multiple times).

And riscv64, arm64, x86 also has the 7 bit  of stack entropy.

for i in $(seq 1 1000); do
	echo "REPORT_STACK" >/sys/kernel/debug/provoke-crash/DIRECT
done
offsets=$(dmesg | grep 'Stack offset' | cut -d: -f3 | sort | uniq -c |
sort -n | wc -l)
echo "$(uname -m) bits of stack entropy: $(echo "obase=2; $offsets" | bc
| wc -L)"

> 
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
>> Suggested-by: Huacai Chen <chenhuacai@...nel.org>
> 
> Thanks for adding this and getting it tested!
> 
> Reviewed-by: Kees Cook <kees@...nel.org>
>