linux-kernel - Re: [PATCH] PCI: keystone: Fix && vs || typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfe47606-1146-4e1e-b349-23a3a60b7629@ti.com>
Date: Sat, 20 Jul 2024 11:35:31 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Kishon Vijay Abraham I <kishon@...nel.org>,
        Lorenzo Pieralisi
	<lpieralisi@...nel.org>,
        Krzysztof Wilczyński
	<kw@...ux.com>,
        Rob Herring <robh@...nel.org>, Bjorn Helgaas
	<bhelgaas@...gle.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Niklas Cassel <cassel@...nel.org>,
        Siddharth Vadapalli <s-vadapalli@...com>,
        Uwe Kleine-König
	<u.kleine-koenig@...gutronix.de>,
        Damien Le Moal <dlemoal@...nel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Aleksandr Mishin
	<amishin@...rgos.ru>,
        Vignesh Raghavendra <vigneshr@...com>,
        Jan Kiszka
	<jan.kiszka@...mens.com>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] PCI: keystone: Fix && vs || typo

On Fri, Jul 19, 2024 at 06:53:26PM -0500, Dan Carpenter wrote:
> This code accidentally uses && where || was intended.  It potentially
> results in a NULL dereference.
> 
> Fixes: 86f271f22bbb ("PCI: keystone: Add workaround for Errata #i2037 (AM65x SR 1.0)")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thank you for the fix.

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

Regards,
Siddharth.