linux-kernel - Re: [PATCH v3 2/2] leds: Add LED1202 I2C driverr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52544eec-60d0-42fa-bdb0-ffe56627c426@web.de>
Date: Sun, 21 Jul 2024 15:55:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>,
 linux-leds@...r.kernel.org, Lee Jones <lee@...nel.org>,
 Pavel Machek <pavel@....cz>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] leds: Add LED1202 I2C driverr

> The LED1202 is a 12-channel low quiescent current LED driver.
…

1. How do you think about to improve such a change description with imperative wordings?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94

2. Would you like to avoid a typo in the summary phrase?

…
> +++ b/drivers/leds/leds-st1202.c
> @@ -0,0 +1,899 @@
…
> +#define ST1202_LED_CHANNEL_10		10
> +#define ST1202_LED_CHANNEL_11		11
> +#define ST1202_MAX_LEDS			12
…
> +#define ST1202_PATTERN_6		6
> +#define ST1202_PATTERN_7		7
> +#define ST1202_PATTERNS_NR		8

Can such identifiers be a bit nicer as part of enumerations?

…
> +static ssize_t st1202_patt_seq_rep_show(struct device *dev,
> +					struct device_attribute *attr, char *buf)
> +{
…
> +	chip = dev_get_drvdata(dev);
> +
> +	mutex_lock(&chip->lock);
…
> +	mutex_unlock(&chip->lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&chip->lock);”?
https://elixir.bootlin.com/linux/v6.10/source/include/linux/mutex.h#L196

Regards,
Markus