linux-kernel - Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39542eb6-8616-468b-889e-d9e1db5bcac0@web.de>
Date: Sun, 21 Jul 2024 17:06:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dingxian Wen <shawn.wen@...k-chips.com>,
 Dmitry Osipenko <dmitry.osipenko@...labora.com>,
 Shreeya Patel <shreeya.patel@...labora.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, kernel@...labora.com,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 Heiko Stübner <heiko@...ech.de>,
 Jose Abreu <Jose.Abreu@...opsys.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Michael Turquette <mturquette@...libre.com>,
 Nelson Costa <Nelson.Costa@...opsys.com>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Stephen Boyd <sboyd@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi
 input driver

…
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -0,0 +1,2763 @@
…
> +static void hdmirx_writel(struct snps_hdmirx_dev *hdmirx_dev, int reg, u32 val)
> +{
…
> +	spin_lock_irqsave(&hdmirx_dev->rst_lock, lock_flags);
> +	writel(val, hdmirx_dev->regs + reg);
> +	spin_unlock_irqrestore(&hdmirx_dev->rst_lock, lock_flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);”?
https://elixir.bootlin.com/linux/v6.10/source/include/linux/spinlock.h#L574

Regards,
Markus