linux-kernel - Re: [PATCH v7] kbuild: add script and target to generate pacman package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f85f96a0-6ac0-4a44-a450-f23cde5a00c1@t-8ch.de>
Date: Sun, 21 Jul 2024 19:21:16 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>, "Jan Alexander Steffens (heftig)" <heftig@...hlinux.org>, 
	Christian Heusel <christian@...sel.eu>, linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v7] kbuild: add script and target to generate pacman
 package

On 2024-07-22 01:02:43+0000, Masahiro Yamada wrote:
> On Sun, Jul 21, 2024 at 11:57 PM Thomas Weißschuh <linux@...ssschuh.net> wrote:
> > On 2024-07-21 22:42:12+0000, Masahiro Yamada wrote:
> > > On Sun, Jul 21, 2024 at 9:11 PM Nathan Chancellor <nathan@...nel.org> wrote:
> > > > On Sun, Jul 21, 2024 at 03:58:49PM +0900, Masahiro Yamada wrote:
> > > > > On Sun, Jul 21, 2024 at 12:32 PM Nathan Chancellor <nathan@...nel.org> wrote:

<snip>

> > > > > I believe this is a separate issue, but
> > > > > Debian/Ubuntu provides a 'makepkg' package, which fails
> > > > > with 'User defined signal 1' error.
> > > > >
> > > > > After 'sudo apt install makepkg',
> > > > >
> > > > > masahiro@zoe:~/ref/linux-next((HEAD detached from origin/master))$ cat
> > > > > /etc/os-release
> > > > > PRETTY_NAME="Ubuntu 24.04 LTS"
> > > > > NAME="Ubuntu"
> > > > > VERSION_ID="24.04"
> > > > > VERSION="24.04 LTS (Noble Numbat)"
> > > > > VERSION_CODENAME=noble
> > > > > ID=ubuntu
> > > > > ID_LIKE=debian
> > > > > HOME_URL="https://www.ubuntu.com/"
> > > > > SUPPORT_URL="https://help.ubuntu.com/"
> > > > > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
> > > > > PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
> > > > > UBUNTU_CODENAME=noble
> > > > > LOGO=ubuntu-logo
> > > > > masahiro@zoe:~/ref/linux-next((HEAD detached from origin/master))$
> > > > > makepkg --version
> > > > > makepkg (pacman) 6.0.2
> > > > > Copyright (c) 2006-2021 Pacman Development Team <pacman-dev@...hlinux.org>.
> > > > > Copyright (C) 2002-2006 Judd Vinet <jvinet@...oflux.org>.
> > > > >
> > > > > This is free software; see the source for copying conditions.
> > > > > There is NO WARRANTY, to the extent permitted by law.
> > > > > masahiro@zoe:~/ref/linux-next((HEAD detached from origin/master))$ git
> > > > > log --oneline -2
> > > > > 5dcaebb67ad9 (HEAD) kbuild: add script and target to generate pacman package
> > > > > 41c196e567fb (tag: next-20240719, origin/master, origin/HEAD) Add
> > > > > linux-next specific files for 20240719
> > > > > masahiro@zoe:~/ref/linux-next((HEAD detached from origin/master))$
> > > > > make defconfig  pacman-pkg
> > > > > *** Default configuration is based on 'x86_64_defconfig'
> > > > > #
> > > > > # No change to .config
> > > > > #
> > > > > objtree="/home/masahiro/ref/linux-next" \
> > > > > BUILDDIR="" \
> > > >
> > > > It is not related to this issue but I don't think this should be empty.
> > > > 'realpath pacman' does not appear to work here, I was able to fix this
> > > > with the following diff:
> > > >
> > > > diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> > > > index 94357f47d2fa..b0fd44a40075 100644
> > > > --- a/scripts/Makefile.package
> > > > +++ b/scripts/Makefile.package
> > > > @@ -148,7 +148,7 @@ PHONY += pacman-pkg
> > > >  pacman-pkg:
> > > >         @ln -srf $(srctree)/scripts/package/PKGBUILD $(objtree)/PKGBUILD
> > > >         +objtree="$(realpath $(objtree))" \
> > > > -               BUILDDIR="$(realpath pacman)" \
> > > > +               BUILDDIR="$(realpath $(objtree))/pacman" \
> > >
> > >
> > > Right.
> > >
> > > $(realpath pacman) expands to empty
> > > if 'pacman' does not exist yet.
> > > Your fix is correct.
> >
> > I'm wondering how it worked for me, as I specifically tested this case.
> > But I'm fine with the proposal.
> >
> > Shouldn't it be "$(realpath ./pacman)" though?
> 
> 
> No.
> 
> Aa I said, $(realpath ./pacman) expands to an empty string
> if ./pacman does not exist.

My bad, I misread the braces and thought the code was doing
BUILDDIR="$(realpath $(objtree)/pacman)"


Thomas