linux-kernel - Re: [PATCH v1 1/1] Input: gpio-keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zp1H8UC2MLZizjHn@qwark.sigxcpu.org>
Date: Sun, 21 Jul 2024 19:40:01 +0200
From: Guido Günther <agx@...xcpu.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
	Hermes Zhang <chenhuiz@...s.com>, Tony Lindgren <tony@...mide.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	phone-devel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

Hi,
On Tue, May 14, 2024 at 06:05:20PM +0200, Guido Günther wrote:
> Hi,
> On Mon, May 13, 2024 at 03:13:53PM -0700, Dmitry Torokhov wrote:
> > Hi Guido,
> > 
> > On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote:
> > > This helps user space to figure out which keys should be used to unidle a
> > > device. E.g on phones the volume rocker should usually not unblank the
> > > screen.
> > 
> > How exactly this is supposed to be used? We have "disabled" keys and
> > switches attribute because this function can be controlled at runtime
> > from userspace while wakeup control is a static device setting.
> 
> Current Linux userspace usually unblanks/unidles a device on every
> keypress. That is usually not the expected result on phones where often
> only the power button and e.g. some home buttons should do this.
> 
> These keys usually match the keys that are used as wakeup sources to
> bring a device out of suspend. So if we export the wakeup keys to
> userspace we can pick some sensible defaults (overridable via hwdb¹).
> 
> > Kernel also does not really know if the screen should be unblanked or
> > not, if a button or switch is configured for wake up the kernel will go
> > through wakeup process all the same and then userspace can decide if it
> > should stay woken up or not.
> 
> Yes, we merely want that as a hint to figure out sensible defaults in
> userspace (which might be a subset of the wakeup keys).

Is there anything I can do to get this applied (currently we play
catchup per device when the wakup keys change) ?

Cheers,
 -- Guido

> 
> Cherrs,
>  -- Guido
> 
> ¹) See https://gitlab.gnome.org/World/Phosh/gmobile/-/blob/main/data/61-gmobile-wakeup.hwdb?ref_type=heads#L57-L59
> 
> > 
> > Thanks.
> > 
> > -- 
> > Dmitry
> >