linux-kernel - Re: [PATCH v3 2/2] selftests/bpf: integrate test_xdp_veth into test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a348aa4d-d2c2-48f5-a1ed-4f97ffd093d7@bootlin.com>
Date: Sun, 21 Jul 2024 21:25:05 +0200
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: Daniel Borkmann <daniel@...earbox.net>,
 Alexei Starovoitov <ast@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 Simon Horman <horms@...nel.org>
Cc: ebpf@...uxfoundation.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v3 2/2] selftests/bpf: integrate test_xdp_veth into
 test_progs

Hello Daniel,

On 7/19/24 17:14, Daniel Borkmann wrote:
> On 7/16/24 12:13 PM, Alexis Lothoré (eBPF Foundation) wrote:

[...]

>> +    nstoken = open_netns(config[index].namespace);
>> +    if (!ASSERT_OK_PTR(nstoken, "switch to remote veth namespace"))
>> +        return -1;
>> +    interface = if_nametoindex(config[index].remote_veth);
>> +    if (!ASSERT_NEQ(interface, 0, "non zero interface index"))
>> +        return -1;
> 
> Missing `close_netns(nstoken);` in error path here, otherwise looks reasonable
> to me.
Ah yes, good catch, thanks. v4 incoming with the corresponding fix.

Thanks,
Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com