linux-kernel - Re: [PATCH v3 3/7] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller

Open Source and information security mailing list archives

Message-ID: <CAJM55Z8uo-Z_9ruyqygK1pbBCTkCxMBVoF8GD2dajhTKOYrAfA@mail.gmail.com>
Date: Sun, 21 Jul 2024 17:07:57 -0500
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Drew Fustini <dfustini@...storrent.com>, Jisheng Zhang <jszhang@...nel.org>, 
	Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, Yangtao Li <frank.li@...o.com>, 
	Thomas Bonnefille <thomas.bonnefille@...tlin.com>, 
	Emil Renner Berthing <emil.renner.berthing@...onical.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/7] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller

Drew Fustini wrote:
> Add node for the AP_SUBSYS clock controller on the T-Head TH1520 SoC.
>
> Link: https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf
> Link: https://git.beagleboard.org/beaglev-ahead/beaglev-ahead/-/tree/main/docs
> Signed-off-by: Drew Fustini <dfustini@...storrent.com>
> ---
>  arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index d2fa25839012..10a38ed55658 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -5,6 +5,7 @@
>   */
>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/thead,th1520-clk-ap.h>
>
>  / {
>  	compatible = "thead,th1520";
> @@ -161,6 +162,13 @@ soc {
>  		dma-noncoherent;
>  		ranges;
>
> +		clk: clock-controller@...f010000 {
> +			compatible = "thead,th1520-clk-ap";
> +			reg = <0xff 0xef010000 0x0 0x1000>;
> +			clocks = <&osc>;
> +			#clock-cells = <1>;
> +		};

Please add this node so nodes are still sorted by address.

> +
>  		plic: interrupt-controller@...8000000 {
>  			compatible = "thead,th1520-plic", "thead,c900-plic";
>  			reg = <0xff 0xd8000000 0x0 0x01000000>;
>
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives