linux-kernel - Re: [PATCH v5 1/4] dt-bindings: mfd: Add Analog Devices ADP5585

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f962a71c-6be7-4ad2-9753-e1f9ab7a38a0@kernel.org>
Date: Sun, 21 Jul 2024 11:23:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Uwe Kleine-König <ukleinek@...nel.org>,
 Haibo Chen <haibo.chen@....com>, Clark Wang <xiaoning.wang@....com>,
 Frank Li <Frank.li@....com>
Subject: Re: [PATCH v5 1/4] dt-bindings: mfd: Add Analog Devices ADP5585

On 19/07/2024 22:39, Laurent Pinchart wrote:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-reserved-ranges: true
> +
> +  "#pwm-cells":
> +    const: 3
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - "#gpio-cells"
> +  - "#pwm-cells"
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,adp5585-01
> +    then:
> +      properties:
> +        gpio-reserved-ranges: false
> +    else:
> +      properties:
> +        gpio-reserved-ranges:
> +          items:
> +            - const: 5
> +            - const: 1

Why reserved ranges are fixed? If they pins are *always* not accessible,
then these are not GPIOs. This really looks incorrect.

Anyway, testing reports failures which *must* be addressed, one way or
another.


Best regards,
Krzysztof