linux-kernel - Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpzqHg_idtElXcw3@gallifrey>
Date: Sun, 21 Jul 2024 10:59:42 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>
Cc: allison.henderson@...cle.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

* Zhu Yanjun (yanjun.zhu@...ux.dev) wrote:
> 在 2024/6/1 1:33, linux@...blig.org 写道:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> > 
> > Remove it.
> > 
> Need Fixes?
> 
> Fixes: 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration")

I've not been using Fixes on these, because they
have no actual consequence - there's no need
for stable or downstream to pick them up, which is
what Fixes is often used for.

> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>

Thanks,

Dave

> Zhu Yanjun
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >   net/rds/ib_rdma.c | 4 ----
> >   1 file changed, 4 deletions(-)
> > 
> > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> > index 8f070ee7e742..d1cfceeff133 100644
> > --- a/net/rds/ib_rdma.c
> > +++ b/net/rds/ib_rdma.c
> > @@ -40,10 +40,6 @@
> >   #include "rds.h"
> >   struct workqueue_struct *rds_ib_mr_wq;
> > -struct rds_ib_dereg_odp_mr {
> > -	struct work_struct work;
> > -	struct ib_mr *mr;
> > -};
> >   static void rds_ib_odp_mr_worker(struct work_struct *work);
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/