linux-kernel - Re: [RFC PATCH v3 08/37] dt-bindings: Add binding for kalray,coolidge-dsu-clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8147ecaa95ad514a6d8c13662ada7cdc.sboyd@kernel.org>
Date: Mon, 22 Jul 2024 14:45:50 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Conor Dooley <conor+dt@...nel.org>, Jonathan Borne <jborne@...rayinc.com>, Julian Vetter <jvetter@...rayinc.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh@...nel.org>, Yann Sionneau <ysionneau@...rayinc.com>, linux-kernel@...r.kernel.org
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [RFC PATCH v3 08/37] dt-bindings: Add binding for kalray,coolidge-dsu-clock

Quoting ysionneau@...rayinc.com (2024-07-22 02:41:19)
> From: Yann Sionneau <ysionneau@...rayinc.com>
> 
> Add binding for Kalray Coolidge DSU (Debug System Unit) clock.
> 
> Signed-off-by: Yann Sionneau <ysionneau@...rayinc.com>
> ---
> 
> Notes:
> 
> V2 -> V3: New patch
> ---
>  .../clock/kalray,coolidge-dsu-clock.yaml      | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/kalray,coolidge-dsu-clock.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/kalray,coolidge-dsu-clock.yaml b/Documentation/devicetree/bindings/clock/kalray,coolidge-dsu-clock.yaml
> new file mode 100644
> index 0000000000000..a7f6239b17c12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/kalray,coolidge-dsu-clock.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/kalray,coolidge-dsu-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kalray Coolidge DSU Clock

Nobody knows what DSU is here. Just spell it out and then put the
acronym:

	Debug System Unit (DSU)

> +
> +maintainers:
> +  - Jonathan Borne <jborne@...rayinc.com>
> +  - Julian Vetter <jvetter@...rayinc.com>
> +  - Yann Sionneau <ysionneau@...rayinc.com>
> +
> +description: |
> +  DSU Clock is a free running counter that runs at Cluster clock frequency.
> +
> +properties:
> +  compatible:
> +    const: kalray,coolidge-dsu-clock
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - reg
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dsu_clock@...180 {
> +        compatible = "kalray,coolidge-dsu-clock";
> +        reg = <0x00 0xa44180 0x00 0x08>;

This looks like it's part of some bigger module, possible DSU in
general. Is that true? If so, please implement the binding for DSU
instead.