linux-kernel - Re: [PATCH] dt-bindings: ata: rockchip-dwc-ahci: add missing power-domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0e65581-0f05-4143-bc45-0b681ef2bff6@kernel.org>
Date: Mon, 22 Jul 2024 10:15:17 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Heiko Stuebner <heiko@...ech.de>, cassel@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 sebastian.reichel@...labora.com, linux-ide@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 u.kleine-koenig@...libre.com
Subject: Re: [PATCH] dt-bindings: ata: rockchip-dwc-ahci: add missing
 power-domains

On 7/21/24 05:57, Heiko Stuebner wrote:
> The Rockchip variant of the dwc-ahci controller does have and need power-
> domains to work, though the binding does not mention them, making dtccheck
> quite unhappy:
> 
>   DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb
> /home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: sata@...00000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>         from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml#
> 
> Fix that by adding the missing power-domain property to the binding.
> 
> Fixes: 85b0e13b19c2 ("dt-bindings: ata: dwc-ahci: add Rockchip RK3588")
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>

I queued this as a fix for 6.11. Will send it out once rc1 is out. Thanks !

> ---
>  Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> index b5e5767d86988..13eaa8d9a16e5 100644
> --- a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> @@ -35,6 +35,9 @@ properties:
>    ports-implemented:
>      const: 1
>  
> +  power-domains:
> +    maxItems: 1
> +
>    sata-port@0:
>      $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port
>  

-- 
Damien Le Moal
Western Digital Research