linux-kernel - Re: [PATCH v6 4/4] pwm: adp5585: Add Analog Devices ADP5585 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <i3rk2h4hzwzlx5fkizhdvz7xz6sboy3jrygpgaj6qv443yvjny@mpbl5g5agxav>
Date: Mon, 22 Jul 2024 09:33:46 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>, 
	Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Lee Jones <lee@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Haibo Chen <haibo.chen@....com>, 
	Clark Wang <xiaoning.wang@....com>, Frank Li <Frank.li@....com>
Subject: Re: [PATCH v6 4/4] pwm: adp5585: Add Analog Devices ADP5585 support

On Sun, Jul 21, 2024 at 07:00:49PM +0300, Laurent Pinchart wrote:
> From: Clark Wang <xiaoning.wang@....com>
> 
> The ADP5585 is a 10/11 input/output port expander with a built in keypad
> matrix decoder, programmable logic, reset generator, and PWM generator.
> This driver supports the PWM function using the platform device
> registered by the core MFD driver.
> 
> The driver is derived from an initial implementation from NXP, available
> in commit 113113742208 ("MLK-25922-1 pwm: adp5585: add adp5585 PWM
> support") in their BSP kernel tree. It has been extensively rewritten.
> 
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

As expected I'm happy with this patch now. If you respin, consider
adding a comment to .request() describing the effect of the register
access there. I guess it's about pinmux, so something like:

	/* Configure the XYZ pin as PWM output */

(with XYZ replaced by something sensible of course).

It's fine for me if this patch gets in via MFD as suggested in the cover
letter.

Acked-by: Uwe Kleine-König <ukleinek@...nel.org>

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)