linux-kernel - Re: [PATCH 03/12] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29c10415-4b59-4aff-bfef-8cfaf090e361@linaro.org>
Date: Mon, 22 Jul 2024 10:36:57 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Dang Huynh <danct12@...eup.net>, Bjorn Andersson <andersson@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] arm64: dts: qcom: sm6115-pro1x: Add Goodix
 Touchscreen

On 22.07.2024 9:10 AM, Dang Huynh wrote:
> The Fxtec Pro1X touchscreen uses Goodix GT9286 chip.
> 
> Signed-off-by: Dang Huynh <danct12@...eup.net>
> ---
>  arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 49 +++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> index 43b4bee72dd8..d91d31646b29 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> @@ -62,6 +62,20 @@ key-volume-up {
>  			wakeup-source;
>  		};
>  	};
> +
> +	ts_vdd_supply: ts-vdd-supply {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ts_vdd_supply";
> +		gpio = <&pca9534 3 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	ts_vddio_supply: ts-vddio-supply {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ts_vddio_supply";
> +		gpio = <&pca9534 2 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};

I suppose you don't know the voltages for these?

>  };
>  
>  &dispcc {
> @@ -86,6 +100,27 @@ pca9534: gpio@21 {
>  	};
>  };
>  
> +&i2c2 {
> +	status = "okay";
> +	/* Clock frequency was not specified downstream, let's park it to 100 KHz */
> +	clock-frequency = <100000>;
> +
> +	touchscreen@14 {
> +		compatible = "goodix,gt9286";
> +		reg = <0x14>;

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ts_int_n>, <&ts_rst_n>;

reverse order, shift these down below supplies

> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <80 IRQ_TYPE_LEVEL_LOW>;

interrupts-extended

Konrad