[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE8JAfy9NtBa--DnUt2AEZPFnvjU6idj8DqUbaeLaH0DMFvuhw@mail.gmail.com>
Date: Mon, 22 Jul 2024 16:38:00 +0800
From: Yanjun Yang <yangyj.ee@...il.com>
To: Philippe CORNU <philippe.cornu@...s.st.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
Yannick Fertre <yannick.fertre@...s.st.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver
On Fri, Jun 28, 2024 at 8:47 PM Philippe CORNU
<philippe.cornu@...s.st.com> wrote:
>
>
>
> On 1/29/24 11:41, Raphael Gallais-Pou wrote:
> >
> > This patch series aims to add several features of the dw-mipi-dsi phy
> > driver that are missing or need to be updated.
> >
> > First patch update a PM macro.
> >
> > Second patch adds runtime PM functionality to the driver.
> >
> > Third patch adds a clock provider generated by the PHY itself. As
> > explained in the commit log of the second patch, a clock declaration is
> > missing. Since this clock is parent of 'dsi_k', it leads to an orphan
> > clock. Most importantly this patch is an anticipation for future
> > versions of the DSI PHY, and its inclusion within the display subsystem
> > and the DRM framework.
> >
> > Last patch fixes a corner effect introduced previously. Since 'dsi' and
> > 'dsi_k' are gated by the same bit on the same register, both reference
> > work as peripheral clock in the device-tree.
> >
This patch (commit id:185f99b614427360) seems to break the dsi of
stm32f469 chip.
I'm not familiar with the drm and the clock framework, maybe it's
because there is no
"ck_dsi_phy" defined for stm32f469.
PS: Sorry for receiving multiple copies of this email, I forgot to
use plain text mode last time.
> > ---
> > Changes in v3-resend:
> > - Removed last patch as it has been merged
> > https://lore.kernel.org/lkml/bf49f4c9-9e81-4c91-972d-13782d996aaa@foss.st.com/
> >
> > Changes in v3:
> > - Fix smatch warning (disable dsi->pclk when clk_register fails)
> >
> > Changes in v2:
> > - Added patch 1/4 to use SYSTEM_SLEEP_PM_OPS instead of old macro
> > and removed __maybe_used for accordingly
> > - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS
> >
> > Raphael Gallais-Pou (3):
> > drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro
> > drm/stm: dsi: expose DSI PHY internal clock
> >
> > Yannick Fertre (1):
> > drm/stm: dsi: add pm runtime ops
> >
> > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 279 ++++++++++++++++++++++----
> > 1 file changed, 238 insertions(+), 41 deletions(-)
> >
>
> Hi Raphaël & Yannick,
> Applied on drm-misc-next.
> Many thanks,
> Philippe :-)
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@...md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
Powered by blists - more mailing lists