linux-kernel - Re: [PATCH v2] mtd: spi-nor: macronix: Add support for serial NOR flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2VYGD0191M5.30VXXMSA7N267@kernel.org>
Date: Mon, 22 Jul 2024 11:20:25 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Cheng Ming Lin" <linchengming884@...il.com>,
 <tudor.ambarus@...aro.org>, <pratyush@...nel.org>,
 <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
 <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Cc: <leoyu@...c.com.tw>, <alvinzhou@...c.com.tw>, "Cheng Ming Lin"
 <chengminglin@...c.com.tw>
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: Add support for serial NOR
 flash

On Mon Jul 22, 2024 at 10:49 AM CEST, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@...c.com.tw>
>
> MX66U1G45G and MX66L2G45G are Macronix serial NOR flash.
>
> These flashes have been tested on Xilinx Zynq-picozed board
> using MXIC SPI controller.

I've asked for a changelog. Now, what you've sent is a v2 (of what
seems to be a split off of a split off). Before sending out another
version, please carefully read:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

To be clear, please explain why this is a split off of the larger
series, what has changed (or if nothing has changed then state so).
Why did you split it even more (before it were two patches).

Honestly, back when Jaime submitted these patches, I already spent
way too much time to review this stuff just to get it dropped or
handed over to another employee who then comes back very late.
Please align your workflow at Macronix and get an internal review
and some training how to submit patches upstream and don't put that
burden on maintainers.

Thanks,
-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)