linux-kernel - [RFC PATCH] mm: keep LRU order by move unisolated folios to tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240722102338.2567810-1-zhaoyang.huang@unisoc.com>
Date: Mon, 22 Jul 2024 18:23:38 +0800
From: "zhaoyang.huang" <zhaoyang.huang@...soc.com>
To: Andrew Morton <akpm@...ux-foundation.org>, Yu Zhao <yuzhao@...gle.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        Zhaoyang Huang
	<huangzhaoyang@...il.com>, <steve.kang@...soc.com>
Subject: [RFC PATCH] mm: keep LRU order by move unisolated folios to tail

From: Zhaoyang Huang <zhaoyang.huang@...soc.com>

Unlike legacy LRU management, MGLRU will switch to other zones or types
when current lrugen[gen][type][zone] scanning failed, which means skipped
folios could become available in next scan. This commit would like to
suggest to keep the LRU's order by moving unisolated folios to the tail
of LRU during the first 2 round scan to avoid potential livelock on the
unisolated ones.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
---
 mm/vmscan.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 2e34de9cd0d4..cd1f38bb1d45 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4397,7 +4397,10 @@ static int scan_folios(struct lruvec *lruvec, struct scan_control *sc,
 		}
 
 		if (skipped_zone) {
-			list_splice(&moved, head);
+			if (sc->priority > DEF_PRIORITY - 2)
+				list_splice_tail(&moved, head);
+			else
+				list_splice(&moved, head);
 			__count_zid_vm_events(PGSCAN_SKIP, zone, skipped_zone);
 			skipped += skipped_zone;
 		}
-- 
2.25.1