linux-kernel - Re: [PATCH AUTOSEL 6.8 15/24] usb: dwc3: core: Access XHCI address space temporarily to read port info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zp5XDcgS4Woh4QJc@sashalap>
Date: Mon, 22 Jul 2024 08:56:45 -0400
From: Sasha Levin <sashal@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Krishna Kurapati <quic_kriskura@...cinc.com>,
	Bjorn Andersson <quic_bjorande@...cinc.com>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
	Johan Hovold <johan+linaro@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.8 15/24] usb: dwc3: core: Access XHCI address
 space temporarily to read port info

On Wed, Jun 05, 2024 at 01:54:12PM +0200, Johan Hovold wrote:
>On Wed, Jun 05, 2024 at 07:50:25AM -0400, Sasha Levin wrote:
>> From: Krishna Kurapati <quic_kriskura@...cinc.com>
>>
>> [ Upstream commit 921e109c6200741499ad0136e41cca9d16431c92 ]
>>
>> All DWC3 Multi Port controllers that exist today only support host mode.
>> Temporarily map XHCI address space for host-only controllers and parse
>> XHCI Extended Capabilities registers to read number of usb2 ports and
>> usb3 ports present on multiport controller. Each USB Port is at least HS
>> capable.
>>
>> The port info for usb2 and usb3 phy are identified as num_usb2_ports
>> and num_usb3_ports and these are used as iterators for phy operations
>> and for modifying GUSB2PHYCFG/ GUSB3PIPECTL registers accordingly.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
>> Reviewed-by: Bjorn Andersson <quic_bjorande@...cinc.com>
>> Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
>> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
>> Tested-by: Johan Hovold <johan+linaro@...nel.org>
>> Link: https://lore.kernel.org/r/20240420044901.884098-3-quic_kriskura@quicinc.com
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>Same here. Not a fix. Please drop.

I'll drop the ones you've pointed out, thanks!

-- 
Thanks,
Sasha