[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zp5asqhipQHEoviM@five231003>
Date: Mon, 22 Jul 2024 18:42:18 +0530
From: Kousik Sanagavarapu <five231003@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>, Nishanth Menon <nm@...com>,
Santosh Shilimkar <ssantosh@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: watchdog: ti,davinci-wdt: convert
to dtschema
On Mon, Jul 22, 2024 at 10:15:03AM +0200, Krzysztof Kozlowski wrote:
> On 21/07/2024 18:28, Kousik Sanagavarapu wrote:
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,davinci-wdt
> > + - ti,keystone-wdt
>
> This does not match the original binding and commit msg did not explain
> why such change is necessary.
I don't understand. Do you mean both the compatibles are always
compulsory? Meaning
compatible:
items:
- const: ti,davinci-wdt
- const: ti,keystone-wdt
It is enum because I intended it to align with the subsequent patch
which changes DTS.
> This also does not match DTS.
Yes. I've asked about changing the DTS in the subsequent patch.
Thanks for the review
Powered by blists - more mailing lists